This is an automated email from the ASF dual-hosted git repository. voonhous pushed a commit to tag rfc-105-pre-cleanup in repository https://gitbox.apache.org/repos/asf/hudi.git
commit 8a84c553f3de8e135084543de1491a8a01fa23e8 Author: voon <[email protected]> AuthorDate: Tue May 26 17:12:38 2026 +0800 ci(trino): consolidate build + test in hudi_trino_ci, drop stale bot.yml job Folds the connector test step into hudi_trino_ci.yml so every PR that touches hudi-trino-plugin both builds and runs the test suite. To run tests we need Trino's test-jars (trino-spi, trino-filesystem, trino-hive at the tests classifier), which are not published to Maven Central. The workflow now checks out trinodb/trino at tag 481 and runs `mvn install -pl :trino-spi,:trino-filesystem,:trino-hive,:trino-main -am -DskipTests` to populate them in the local m2. -Dair.check.skip-all=true disables Trino's airbase enforcer rules on the truncated reactor. The JDK 17 stage now also installs hudi-client-common and hudi-java-client because the gated hudi-trino-tests profile pulls them in for the test classpath. Removes the test-hudi-trino-plugin block in bot.yml (JDK 23, no Trino profile, obsolete api.version flag); the new workflow supersedes it. --- .github/workflows/bot.yml | 27 --------------------------- .github/workflows/hudi_trino_ci.yml | 23 ++++++++++++++++++----- 2 files changed, 18 insertions(+), 32 deletions(-) diff --git a/.github/workflows/bot.yml b/.github/workflows/bot.yml index 0f4950993773..9d4d2434424e 100644 --- a/.github/workflows/bot.yml +++ b/.github/workflows/bot.yml @@ -1458,30 +1458,3 @@ jobs: run: mvn test -Punit-tests -Djava17 -Djava.version=17 -D"$SCALA_PROFILE" -D"$FLINK_PROFILE" -pl hudi-examples/hudi-examples-flink $MVN_ARGS - test-hudi-trino-plugin: - runs-on: ubuntu-latest - needs: changes - steps: - - name: Checkout repository - if: needs.changes.outputs.relevant == 'true' - uses: actions/checkout@v5 - - name: Set up JDK 23 - if: needs.changes.outputs.relevant == 'true' - uses: actions/setup-java@v5 - with: - # Note: We are not caching here again, as we want to use the .m2 repository populated by - # the previous step - java-version: '23' - distribution: 'temurin' - architecture: x64 - cache: maven - - name: Build hudi-trino-plugin with JDK 23 - if: needs.changes.outputs.relevant == 'true' - working-directory: ./hudi-trino-plugin - run: - mvn clean install -DskipTests - - name: Test hudi-trino-plugin with JDK 23 - if: needs.changes.outputs.relevant == 'true' - working-directory: ./hudi-trino-plugin - run: - mvn test -Dapi.version=1.44 diff --git a/.github/workflows/hudi_trino_ci.yml b/.github/workflows/hudi_trino_ci.yml index 7153b25c0734..542290978a28 100644 --- a/.github/workflows/hudi_trino_ci.yml +++ b/.github/workflows/hudi_trino_ci.yml @@ -26,7 +26,7 @@ env: jobs: build-and-test: - name: Build connector + name: Build and test connector runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 @@ -40,15 +40,28 @@ jobs: distribution: 'temurin' cache: maven - name: Install upstream Hudi modules (JDK 17) - run: mvn $MVN_ARGS install -pl :hudi-common,:hudi-hive-sync,:hudi-io,:hudi-sync-common -am -Dmaven.test.skip=true -Drat.skip -Dcheckstyle.skip + # hudi-client-common and hudi-java-client are pulled in here for the test stage; + # they live behind the hudi-trino-tests profile but the test step needs them. + run: mvn $MVN_ARGS install -pl :hudi-common,:hudi-hive-sync,:hudi-io,:hudi-sync-common,:hudi-client-common,:hudi-java-client -am -Dmaven.test.skip=true -Drat.skip -Dcheckstyle.skip - name: Set up JDK 25 uses: actions/setup-java@v5 with: java-version: '25' distribution: 'temurin' cache: maven - # Tests live behind the hudi-trino-tests profile (Trino does not publish the - # test-jars we need). -Dmaven.test.skip=true skips test compilation so the build - # resolves cleanly against Maven Central. + # Trino does not publish trino-spi / trino-filesystem / trino-hive test-jars to + # Maven Central. Check out the matching release tag and install just the modules + # whose test classifiers we need into the local m2. + - name: Checkout trinodb/trino at 481 + uses: actions/checkout@v5 + with: + repository: trinodb/trino + ref: '481' + path: trino-src + - name: Install Trino test-jars (JDK 25) + working-directory: trino-src + run: mvn $MVN_ARGS install -pl :trino-spi,:trino-filesystem,:trino-hive,:trino-main -am -DskipTests -Dair.check.skip-all=true - name: Build connector (JDK 25) run: mvn $MVN_ARGS -Phudi-trino -pl hudi-trino-plugin install -Dmaven.test.skip=true + - name: Test connector (JDK 25) + run: mvn $MVN_ARGS -Phudi-trino,hudi-trino-tests -pl hudi-trino-plugin test
