fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3360663439
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -242,10 +242,10 @@ public static HoodieWriteConfig getHoodieClientConfig(
.build())
.withIndexConfig(StreamerUtil.getIndexConfig(conf))
.withPayloadConfig(getPayloadConfig(conf))
- .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
.withEmbeddedTimelineServerReuseEnabled(true) // make write client
embedded timeline service singleton
.withAllowOperationMetadataField(conf.get(FlinkOptions.CHANGELOG_ENABLED))
.withProps(flinkConf2TypedProperties(conf))
+ .withEmbeddedTimelineServerEnabled(enableEmbeddedTimelineService)
Review Comment:
> why moving it around
Good question. The ordering is intentional: user props should still keep
precedence for generic configs such as timeline server reuse and operation
metadata field, while timeline server enablement is controlled by the caller.
The coordinator-side client must enable it, and task-side clients must disable
it. I added an inline comment to make this precedence explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
