voonhous commented on code in PR #18065:
URL: https://github.com/apache/hudi/pull/18065#discussion_r3371736858
##########
hudi-spark-datasource/hudi-spark4-common/src/main/scala/org/apache/spark/sql/adapter/BaseSpark4Adapter.scala:
##########
@@ -261,6 +263,7 @@ abstract class BaseSpark4Adapter extends SparkAdapter with
Logging {
applyVariantLogicalType(builder).named(fieldName)
}
+ // TODO(HUDI-XXXX) drop-spark4.0: when all remaining 4.x adapters are
parquet 1.16+, apply variantType() in this base and delete the no-op default
plus the Spark4_1Adapter override.
Review Comment:
Hudi has moved off JIRA to GitHub issues, so I filed #18935 for the
drop-spark4.0 cleanup and inlined it as `TODO(#18935)`. That issue also tracks
removing the sibling `hudi-spark4.0.x` variant shims.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
