yanghua commented on a change in pull request #2640:
URL: https://github.com/apache/hudi/pull/2640#discussion_r589963858
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -332,7 +331,7 @@ public static String getTablePath(FileSystem fs, Path[]
userProvidedPaths) throw
public static boolean needsScheduleCompaction(Configuration conf) {
return conf.getString(FlinkOptions.TABLE_TYPE)
.toUpperCase(Locale.ROOT)
- .equals(HoodieTableType.MERGE_ON_READ.name())
+ .equals(FlinkOptions.TABLE_TYPE_MERGE_ON_READ)
Review comment:
I am not sure if a definition would be changed. But if we have a fact
source, anywhere we reference it, it's enough. IMO, it's not necessary to
define it more than once. Otherwise, the others would define it in `java` or
`spark` module? Because, we allowed this behavior in `flink` module. It will
add the complexity and the cost of understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
