hudi-agent commented on code in PR #18585:
URL: https://github.com/apache/hudi/pull/18585#discussion_r3383941796
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/utils/SparkValidatorUtils.java:
##########
@@ -83,7 +83,7 @@ public static void runValidators(HoodieWriteConfig config,
Dataset<Row> afterState = getRecordsFromPendingCommits(sqlContext,
partitionsModified, writeMetadata, table, instantTime);
Dataset<Row> beforeState = getRecordsFromCommittedFiles(sqlContext,
partitionsModified, table, afterState.schema());
- Stream<SparkPreCommitValidator> validators =
Arrays.stream(config.getPreCommitValidators().split(","))
+ List<SparkPreCommitValidator> validatorsList =
Arrays.stream(config.getPreCommitValidators().split(","))
Review Comment:
🤖 nit: could we just call this `validators`? The `List` suffix is
hungarian-style and the previous `Stream` version dropped it too.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-io/pom.xml:
##########
@@ -103,6 +103,13 @@
<!-- Required to support older Hive versions that still use Java 8
-->
<target>8</target>
<release>8</release>
+ <annotationProcessorPaths>
+ <path>
Review Comment:
🤖 nit: this Lombok annotation-processor block in hudi-io seems unrelated to
the classloader fix — was it included by mistake? If it's intentional, a brief
note in the PR description on why hudi-io now needs Lombok would help reviewers.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
