voonhous commented on code in PR #18944:
URL: https://github.com/apache/hudi/pull/18944#discussion_r3385419693
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java:
##########
@@ -361,9 +360,12 @@ public IncrementalQueryAnalyzer build() {
/**
* Represents the analyzed query context.
*/
+ @AllArgsConstructor
Review Comment:
Yes, this was an oversight. Changed to `@AllArgsConstructor(access =
AccessLevel.PRIVATE)` to match the original visibility, so `create()` remains
the only entry point. This matters here because the generated constructor
assigns the `Option` fields as-is (the old private constructor wrapped raw
Strings with `Option.ofNullable`), so bypassing `create()` with nulls would
produce a context that NPEs in `isConsumingFromEarliest()`. Also fixed the
`EMPTY` constant accordingly to pass `Option.empty()` instead of `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
