fhan688 commented on PR #18945:
URL: https://github.com/apache/hudi/pull/18945#issuecomment-4667191849
> Thanks for the focused fix. I did another pass over the selected/regex
incremental scheduling flow. The main blocker I see is the existing inline
comment on `ClusteringPlanStrategy#getMissingPartitionsFromCurrentWindow`:
returning `Collections.emptyList()` on the non-incremental path can still be
mutated by `generateClusteringPlan` after `filterPartitionPaths(...)` adds
skipped partitions, so cases like non-incremental scheduling with `RECENT_DAYS`
can throw `UnsupportedOperationException`. Please make that path return a
mutable empty list or keep the caller-owned `ArrayList` when incremental table
service is disabled.
>
> I did not find another correctness issue beyond that. I tried to run `mvn
-pl hudi-client/hudi-client-common -DskipITs -DskipTests=false
-Dtest=TestPartitionAwareClusteringPlanStrategy test`, but this local shell is
on Java 8 and the module compile target requires Java 11, so the run failed
before tests executed.
Good catch. The non-incremental path should still return a caller-mutable
list because `generateClusteringPlan` appends partition-filter skipped
partitions before it later nulls out `missingSchedulePartitions` for non-
incremental scheduling. I will change the helper to return a new
`ArrayList<>()` when incremental table service is disabled and add coverage for
the mutable empty result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
