prashantwason commented on pull request #2494:
URL: https://github.com/apache/hudi/pull/2494#issuecomment-794269612


   @vinothchandar and I discussed simplifying this PR. The following changes 
are to be implemented:
   1. Remove the "reuse" configuration as it does not make sense for 
performance reasons. 
         - When timeline server is used, reuse should be on
         - When timeline server is not used, each executor has its own instance 
of the Metadata Reader and reuse is implicit.
   
   2. Simplify the above code to use the instance variables
   3. Locking is not required because of the usage pattern in #1. Locking will 
still be required in HFileReader because KeyScanner is not thread safe.
   
   
   I am working on updating this PR.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to