danny0405 commented on a change in pull request #2640:
URL: https://github.com/apache/hudi/pull/2640#discussion_r591024300
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -332,7 +331,7 @@ public static String getTablePath(FileSystem fs, Path[]
userProvidedPaths) throw
public static boolean needsScheduleCompaction(Configuration conf) {
return conf.getString(FlinkOptions.TABLE_TYPE)
.toUpperCase(Locale.ROOT)
- .equals(HoodieTableType.MERGE_ON_READ.name())
+ .equals(FlinkOptions.TABLE_TYPE_MERGE_ON_READ)
Review comment:
`HoodieTableType` is an enumeration, but in many cases we need a string
constant, not a method call like `HoodieTableType.name()`, such as the Junit5
parameterized test.
BTW, can we not block this PR because these two options are now introduced
in this PR though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
