yanghua commented on a change in pull request #2659:
URL: https://github.com/apache/hudi/pull/2659#discussion_r592101033
##########
File path: hudi-flink/src/test/java/org/apache/hudi/operator/utils/TestData.java
##########
@@ -70,100 +72,116 @@
/** Data set for testing, also some utilities to check the results. */
public class TestData {
- public static List<RowData> DATA_SET_ONE = Arrays.asList(
- binaryRow(StringData.fromString("id1"), StringData.fromString("Danny"),
23,
+ public static List<RowData> DATA_SET_INSERT = Arrays.asList(
+ insertRow(StringData.fromString("id1"), StringData.fromString("Danny"),
23,
TimestampData.fromEpochMillis(1), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 33,
+ insertRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 33,
TimestampData.fromEpochMillis(2), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id3"), StringData.fromString("Julian"),
53,
+ insertRow(StringData.fromString("id3"), StringData.fromString("Julian"),
53,
TimestampData.fromEpochMillis(3), StringData.fromString("par2")),
- binaryRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
31,
+ insertRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
31,
TimestampData.fromEpochMillis(4), StringData.fromString("par2")),
- binaryRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
+ insertRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
TimestampData.fromEpochMillis(5), StringData.fromString("par3")),
- binaryRow(StringData.fromString("id6"), StringData.fromString("Emma"),
20,
+ insertRow(StringData.fromString("id6"), StringData.fromString("Emma"),
20,
TimestampData.fromEpochMillis(6), StringData.fromString("par3")),
- binaryRow(StringData.fromString("id7"), StringData.fromString("Bob"), 44,
+ insertRow(StringData.fromString("id7"), StringData.fromString("Bob"), 44,
TimestampData.fromEpochMillis(7), StringData.fromString("par4")),
- binaryRow(StringData.fromString("id8"), StringData.fromString("Han"), 56,
+ insertRow(StringData.fromString("id8"), StringData.fromString("Han"), 56,
TimestampData.fromEpochMillis(8), StringData.fromString("par4"))
);
- public static List<RowData> DATA_SET_TWO = Arrays.asList(
+ public static List<RowData> DATA_SET_UPDATE_INSERT = Arrays.asList(
// advance the age by 1
- binaryRow(StringData.fromString("id1"), StringData.fromString("Danny"),
24,
+ insertRow(StringData.fromString("id1"), StringData.fromString("Danny"),
24,
TimestampData.fromEpochMillis(1), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 34,
+ insertRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 34,
TimestampData.fromEpochMillis(2), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id3"), StringData.fromString("Julian"),
54,
+ insertRow(StringData.fromString("id3"), StringData.fromString("Julian"),
54,
TimestampData.fromEpochMillis(3), StringData.fromString("par2")),
- binaryRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
32,
+ insertRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
32,
TimestampData.fromEpochMillis(4), StringData.fromString("par2")),
// same with before
- binaryRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
+ insertRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
TimestampData.fromEpochMillis(5), StringData.fromString("par3")),
// new data
- binaryRow(StringData.fromString("id9"), StringData.fromString("Jane"),
19,
+ insertRow(StringData.fromString("id9"), StringData.fromString("Jane"),
19,
TimestampData.fromEpochMillis(6), StringData.fromString("par3")),
- binaryRow(StringData.fromString("id10"), StringData.fromString("Ella"),
38,
+ insertRow(StringData.fromString("id10"), StringData.fromString("Ella"),
38,
TimestampData.fromEpochMillis(7), StringData.fromString("par4")),
- binaryRow(StringData.fromString("id11"),
StringData.fromString("Phoebe"), 52,
+ insertRow(StringData.fromString("id11"),
StringData.fromString("Phoebe"), 52,
TimestampData.fromEpochMillis(8), StringData.fromString("par4"))
);
- public static List<RowData> DATA_SET_THREE = new ArrayList<>();
+ public static List<RowData> DATA_SET_INSERT_DUPLICATES = new ArrayList<>();
static {
- IntStream.range(0, 5).forEach(i -> DATA_SET_THREE.add(
- binaryRow(StringData.fromString("id1"),
StringData.fromString("Danny"), 23,
+ IntStream.range(0, 5).forEach(i -> DATA_SET_INSERT_DUPLICATES.add(
+ insertRow(StringData.fromString("id1"),
StringData.fromString("Danny"), 23,
TimestampData.fromEpochMillis(1), StringData.fromString("par1"))));
}
// data set of test_source.data
- public static List<RowData> DATA_SET_FOUR = Arrays.asList(
- binaryRow(StringData.fromString("id1"), StringData.fromString("Danny"),
23,
+ public static List<RowData> DATA_SET_SOURCE_INSERT = Arrays.asList(
+ insertRow(StringData.fromString("id1"), StringData.fromString("Danny"),
23,
TimestampData.fromEpochMillis(1000), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 33,
+ insertRow(StringData.fromString("id2"),
StringData.fromString("Stephen"), 33,
TimestampData.fromEpochMillis(2000), StringData.fromString("par1")),
- binaryRow(StringData.fromString("id3"), StringData.fromString("Julian"),
53,
+ insertRow(StringData.fromString("id3"), StringData.fromString("Julian"),
53,
TimestampData.fromEpochMillis(3000), StringData.fromString("par2")),
- binaryRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
31,
+ insertRow(StringData.fromString("id4"), StringData.fromString("Fabian"),
31,
TimestampData.fromEpochMillis(4000), StringData.fromString("par2")),
- binaryRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
+ insertRow(StringData.fromString("id5"), StringData.fromString("Sophia"),
18,
TimestampData.fromEpochMillis(5000), StringData.fromString("par3")),
- binaryRow(StringData.fromString("id6"), StringData.fromString("Emma"),
20,
+ insertRow(StringData.fromString("id6"), StringData.fromString("Emma"),
20,
TimestampData.fromEpochMillis(6000), StringData.fromString("par3")),
- binaryRow(StringData.fromString("id7"), StringData.fromString("Bob"), 44,
+ insertRow(StringData.fromString("id7"), StringData.fromString("Bob"), 44,
TimestampData.fromEpochMillis(7000), StringData.fromString("par4")),
- binaryRow(StringData.fromString("id8"), StringData.fromString("Han"), 56,
+ insertRow(StringData.fromString("id8"), StringData.fromString("Han"), 56,
TimestampData.fromEpochMillis(8000), StringData.fromString("par4"))
);
// merged data set of test_source.data and test_source2.data
- public static List<RowData> DATA_SET_FIVE = Arrays.asList(
- binaryRow(StringData.fromString("id1"), StringData.fromString("Danny"),
24,
+ public static List<RowData> DATA_SET_TEST_SOURCE_MERGED = Arrays.asList(
Review comment:
Rename to `DATA_SET_SOURCE_MERGED` to make it follow the same rule?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
