HuangZhenQiu commented on code in PR #18982:
URL: https://github.com/apache/hudi/pull/18982#discussion_r3399561672
##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -196,6 +196,15 @@
<pattern>com.codahale.metrics.</pattern>
<shadedPattern>org.apache.hudi.com.codahale.metrics.</shadedPattern>
</relocation>
+ <!-- Relocate the bundled flink-metrics-dropwizard bridge into
the hudi namespace.
+ It is recompiled against the relocated
com.codahale.metrics above, so leaving it
+ at the real Flink FQN shadows the genuine wrapper and
breaks any consumer that
+ also depends on flink-metrics-dropwizard with a
NoSuchMethodError on
+
DropwizardHistogramWrapper(com.codahale.metrics.Histogram). -->
+ <relocation>
+ <pattern>org.apache.flink.dropwizard.</pattern>
+
<shadedPattern>org.apache.hudi.org.apache.flink.dropwizard.</shadedPattern>
Review Comment:
Let's use ${flink.bundle.shade.prefix} here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
