nsivabalan commented on a change in pull request #2653:
URL: https://github.com/apache/hudi/pull/2653#discussion_r592751124
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/util/CommitUtils.java
##########
@@ -66,7 +66,8 @@ public static HoodieCommitMetadata
buildMetadata(List<HoodieWriteStat> writeStat
if (extraMetadata.isPresent()) {
extraMetadata.get().forEach(commitMetadata::addMetadata);
}
- commitMetadata.addMetadata(HoodieCommitMetadata.SCHEMA_KEY,
schemaToStoreInCommit);
+ // do we need to set empty string for schema of schema is null ?
+ commitMetadata.addMetadata(HoodieCommitMetadata.SCHEMA_KEY,
schemaToStoreInCommit == null ? "" : schemaToStoreInCommit);
Review comment:
do we need to set empty string for schema if schema is null ? Better to
fix at the datasource layer to set the schema properly rather than silently
setting empty string here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
