nsivabalan commented on code in PR #18085:
URL: https://github.com/apache/hudi/pull/18085#discussion_r3405582834
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamerMetrics.java:
##########
@@ -108,6 +108,20 @@ public void updateStreamerMetrics(long durationInNs) {
}
}
+ @Override
+ public void emitStreamerJobSuccessMetrics() {
Review Comment:
The call chain is wired up via `StreamSync`:
- `HoodieStreamer.ingestOnce()`
([HoodieStreamer.java#L923-L934](https://github.com/apache/hudi/blob/pw_oss_commit_porting_37/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java#L923-L934))
calls `streamSync.reportSuccessMetrics()` on the happy path and
`streamSync.reportFailureMetrics()` in the exception handler.
- `StreamSync.reportSuccessMetrics()` / `reportFailureMetrics()`
([StreamSync.java#L592-L598](https://github.com/apache/hudi/blob/pw_oss_commit_porting_37/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java#L592-L598))
in turn call `metrics.emitStreamerJobSuccessMetrics()` /
`emitStreamerJobFailedMetrics()`.
So on every `ingestOnce()` invocation either the success or the failure
gauge is emitted. Tests covering this are in `TestStreamSync` (`ingestOnce`
success/failure paths verify these calls) and `TestHoodieStreamerMetrics`
(verifies the metric is registered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
