wombatu-kun commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3407924554
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -89,6 +88,7 @@ public class HoodieTableFileSystemView extends
IncrementalTimelineSyncFileSystem
/**
* Flag to determine if closed.
*/
+ @Getter
Review Comment:
The explicit `isClosed()` is still present at
HoodieTableFileSystemView.java:458 in the latest commit (d40c3bd), so this
`@Getter` is still a no-op and the boilerplate was not actually dropped. Remove
lines 458-460 (as done in `RocksDbBasedFileSystemView`) to let `@Getter`
generate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]