vinothchandar commented on a change in pull request #2334:
URL: https://github.com/apache/hudi/pull/2334#discussion_r593862114
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCreateHandle.java
##########
@@ -152,9 +155,9 @@ public void write() {
final String key = keyIterator.next();
HoodieRecord<T> record = recordMap.get(key);
if (useWriterSchema) {
- write(record,
record.getData().getInsertValue(writerSchemaWithMetafields));
+ write(record,
record.getData().getInsertValue(inputSchemaWithMetaFields));
Review comment:
I actually disagree completely :) . Leaking such call hierarchy into a
lower level class will lead to more confusions, if say one more code path uses
this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
