voonhous opened a new pull request, #19000:
URL: https://github.com/apache/hudi/pull/19000
…n instead of per record
collectColumnRangeMetadata iterated the target columns inside the per-record
loop and, for every record and every target field, recomputed values that
depend only on the fixed target field list:
- field.schema().getNonNullType() rebuilds the union-member wrappers for
nullable fields (a fresh HoodieSchema per call), and
- because that non-null schema was a fresh instance per record, its
toAvroSchema() (used for min/max compares) never memoized.
Resolve the non-null HoodieSchema once per target field before the loop and
iterate that precomputed list; holding a stable instance also lets
toAvroSchema() memoize across records. Per-record work (type-support check,
value extraction, min/max/null/value counts) is unchanged, so results are
identical. Covered by the existing column-stats functional tests.
Closes #18999
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
