danny0405 commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3408990198
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineDiffHelper.java:
##########
@@ -125,48 +127,18 @@ private static List<Pair<HoodieInstant, HoodieInstant>>
getPendingActionTransiti
/**
* A diff result of timeline.
*/
+ @AllArgsConstructor
+ @Getter
+ @ToString
Review Comment:
`@ToString` changes the exact `TimelineDiffResult` string from
`TimelineDiffResult{...}` to Lombok’s
`TimelineDiffHelper.TimelineDiffResult(...)` format. This value is logged in
`IncrementalTimelineSyncFileSystemView#runIncrementalSync`, so the refactor is
no longer output-preserving. Since the PR goal is no runtime/observable
behavior change, can we keep the explicit `toString()` here, or otherwise
preserve the previous format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
