hudi-agent commented on code in PR #18957:
URL: https://github.com/apache/hudi/pull/18957#discussion_r3412598095
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v2/ActiveTimelineV2.java:
##########
@@ -602,7 +594,7 @@ protected <T> void transitionPendingState(
} else {
storage.createImmutableFileInPath(getInstantFileNamePath(toInstantFileName),
getInstantWriter(metadata));
}
- LOG.info("Create new file for toInstant ?{}",
getInstantFileNamePath(toInstantFileName));
+ log.info("Create new file for toInstant ?{}",
getInstantFileNamePath(toInstantFileName));
Review Comment:
🤖 nit: the sibling ActiveTimelineV1 fixed this message to `"Create new file
for toInstant? {}"` (space before the placeholder, `?` attached to the word).
Worth applying the same fix here so the two versions stay consistent.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineDiffHelper.java:
##########
@@ -125,40 +126,19 @@ private static List<Pair<HoodieInstant, HoodieInstant>>
getPendingActionTransiti
/**
* A diff result of timeline.
*/
+ @AllArgsConstructor
+ @Getter
public static class TimelineDiffResult {
private final List<HoodieInstant> newlySeenInstants;
private final List<HoodieInstant> finishedCompactionInstants;
private final List<HoodieInstant> finishedOrRemovedLogCompactionInstants;
Review Comment:
🤖 nit: a one-line comment explaining why only `canSyncIncrementally` uses
`@Accessors(fluent = true)` (i.e. preserving the existing
`canSyncIncrementally()` API) would help future readers — the mix of `getXxx()`
and `xxx()` accessors on the same class otherwise looks unintentional.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
