nsivabalan commented on a change in pull request #2438:
URL: https://github.com/apache/hudi/pull/2438#discussion_r594471195



##########
File path: 
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/HoodieDeltaStreamerWrapper.java
##########
@@ -65,7 +65,7 @@ public void scheduleCompact() throws Exception {
     return upsert(WriteOperationType.UPSERT);
   }
 
-  public Pair<SchemaProvider, Pair<String, JavaRDD<HoodieRecord>>> 
fetchSource() throws Exception {
+  public Pair<Pair<SchemaProvider, JavaRDD<HoodieRecord>>, Pair<String, 
String>> fetchSource() throws Exception {

Review comment:
       this is getting out of hand(two pairs within a pair). we can't keep 
adding more Pairs here. I am adding a class to hold the return value here in 
one of my PRs. Lets see if we can rebase once the other PR lands.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to