hudi-agent commented on code in PR #18384:
URL: https://github.com/apache/hudi/pull/18384#discussion_r3425866678
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataFileWriterFactory.java:
##########
@@ -113,13 +115,32 @@ public HoodieFileWriter newParquetFileWriter(
instantTime, taskContextSupplier, populateMetaFields, withOperation);
}
+ /**
+ * Create a parquet RowData writer on a given storage path.
+ *
+ * <p>Convenience overload retained for tests that already have a Flink
RowType in hand;
+ * delegates to the HoodieSchema-based overload via {@link
HoodieSchemaConverter}.
+ */
Review Comment:
🤖 Two concerns on the new Lance path: (a) `populateMetaFields` is sourced
from `config` (HoodieConfig) rather than `tableConfig.populateMetaFields()`
like the sibling Parquet path — inconsistent with the prior-round conclusion
that table config is the source of truth; (b) only a boolean is plumbed into
`HoodieRowDataLanceWriter`, so `META_FIELDS_EXCLUDE_LIST` is silently ignored
and all five meta fields get written even when the user excluded one. Is Lance
intentionally out of scope for selective exclusion in this PR?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
