wombatu-kun commented on code in PR #19030:
URL: https://github.com/apache/hudi/pull/19030#discussion_r3426029124


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -126,6 +128,15 @@
  */
 @ExtendWith(FlinkMiniCluster.class)
 public class ITTestHoodieDataSource {
+  private static final Logger LOG = 
LoggerFactory.getLogger(ITTestHoodieDataSource.class);
+
+  // A streaming read collected via CollectTableSink is terminated by a forced 
SuccessException once it
+  // reaches its expected row count. A benign teardown race (see 
isAcceptableTerminalFailure) can instead
+  // close the source stream mid-read and terminate the job before all rows 
are emitted, leaving an
+  // incomplete result. Re-reading from the same (already committed) table is 
idempotent, so retry a few
+  // times before giving up. See fetchResultWithExpectedNum.

Review Comment:
   Done b7f334f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to