voonhous commented on code in PR #18967: URL: https://github.com/apache/hudi/pull/18967#discussion_r3426527195
########## hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java: ########## @@ -313,8 +315,10 @@ private static void addVectorColumnName(String s, int start, int end, Set<String private Schema avroSchema; private HoodieSchemaType type; - private transient List<HoodieSchemaField> fields; - private transient Map<String, HoodieSchemaField> fieldMap; + // interned instances are shared across threads, so the lazily built caches use double-checked Review Comment: Good catch - reworded. The synchronized DCL was dropped in `8780fc8` for a benign-race single-check; this declaration comment had not caught up. Now matches the `getFields()`/`getFieldMap()` inline comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
