nsivabalan commented on PR #17591: URL: https://github.com/apache/hudi/pull/17591#issuecomment-4765378158
Rebased onto latest master and addressed all open feedback: - Implemented the new abstract `union()` on `ExecutorServiceBasedEngineContext` (was missing the override — would have failed compile). Added `testUnion` mirroring the existing Flink/Java/Local coverage. - Applied the suggested stream-based form (`stream().flatMap(...).collect(toList())`) uniformly across all four list-backed engine contexts and dropped now-unused `ArrayList` imports. - Earlier-round nits already addressed: `entry` → `hoodieData` lambda var; `HoodieJavaRDD::getJavaRDD` method ref. Verified `mvn test -Dtest=TestExecutorServiceBasedEngineContext` (8/8 pass) and TestHoodieFlinkEngineContext / TestHoodieJavaEngineContext (5/5 each). Ready for review. @cshuo @yihua PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
