n3nash commented on a change in pull request #2691:
URL: https://github.com/apache/hudi/pull/2691#discussion_r596231099
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -245,27 +245,20 @@ public KafkaOffsetGen(TypedProperties props) {
return CheckpointUtils.computeOffsetRanges(fromOffsets, toOffsets,
numEvents);
}
- // check up checkpoint offsets is valid or not, if true, return checkpoint
offsets,
- // else return earliest offsets
- private Map<TopicPartition, Long> checkupValidOffsets(KafkaConsumer consumer,
+ /**
+ * Fetch checkpoint offsets for each partition.
+ * @param consumer instance of {@link KafkaConsumer} to fetch offsets from.
+ * @param lastCheckpointStr last checkpoint string.
Review comment:
Should we just rename this to `lastCheckpoint` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
