fhan688 commented on code in PR #19041:
URL: https://github.com/apache/hudi/pull/19041#discussion_r3458467953
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -1059,6 +1061,20 @@ public class FlinkOptions extends HoodieConfig {
.withFallbackKeys("hoodie.clean.fileversions.retained")
.withDescription("Number of file versions to retain. default 5");
+ public static final ConfigOption<Long> CLEAN_MAX_COMMITS_TO_CLEAN =
ConfigOptions
+ .key(HoodieCleanConfig.MAX_COMMITS_TO_CLEAN.key())
Review Comment:
> no need to add option dupilicates for Flink, they are applied
automatically.
Thanks, that makes sense. I checked the Flink write config path again:
`FlinkWriteClients#getHoodieClientConfig` already calls
`withProps(flinkConf2TypedProperties(conf))`, and `flinkConf2TypedProperties`
propagates raw `hoodie.*` options into `HoodieWriteConfig`. The clean/archive
getters then read these values directly from the final props.
So the explicit `FlinkOptions` entries and builder calls are redundant
here. I will remove the added Flink option constants, the explicit propagation
in `FlinkWriteClients`, the related Flink test changes, and update the
PR description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
