hudi-agent commented on code in PR #18938:
URL: https://github.com/apache/hudi/pull/18938#discussion_r3459467640


##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/storage/hadoop/HoodieVariantReconstruction.java:
##########


Review Comment:
   🤖 **Line 151:** The new tests cover the null and throw branches of create 
plus the provider shred and rebuild in isolation, but I do not see one 
exercising the successful create then reconstruct path: the isTarget and 
subschema index alignment and the per-record mapping. Since Spark compaction 
never reaches this AVRO path, would a small round-trip test through 
HoodieVariantReconstruction be worth adding to lock that alignment in?
   
   <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag 
quality.</i></sub>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to