voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3467011413
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiPageSourceProvider.java:
##########
@@ -430,15 +438,8 @@ private static TupleDomain<HiveColumnHandle>
getCombinedPredicate(HudiSplit hudi
private static List<HiveColumnHandle> getHiveColumns(List<ColumnHandle>
columns,
Review Comment:
Done, dropped the unused isBaseFileOnly parameter and its argument at the
call site. The local isBaseFileOnly stays, since it is still used for the
predicate-pushdown / meta-column branches below.
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiPageSourceProvider.java:
##########
@@ -430,15 +438,8 @@ private static TupleDomain<HiveColumnHandle>
getCombinedPredicate(HudiSplit hudi
private static List<HiveColumnHandle> getHiveColumns(List<ColumnHandle>
columns,
Review Comment:
Done, dropped the unused isBaseFileOnly parameter and its argument at the
call site. The local `isBaseFileOnly` stays, since it is still used for the
predicate-pushdown / meta-column branches below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
