nsivabalan commented on code in PR #19062:
URL: https://github.com/apache/hudi/pull/19062#discussion_r3470855947
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -175,6 +183,15 @@ public void setUpMORTestTable() throws IOException {
@AfterEach
public void clean() throws IOException {
+ if (currentTestingServer != null) {
+ try {
+ currentTestingServer.close();
+ } catch (Exception e) {
+ LOG.warn("Failed to close TestingServer in @AfterEach", e);
+ } finally {
+ currentTestingServer = null;
+ }
+ }
Review Comment:
Done in baa816c. Dropped both the `currentTestingServer` field and the
`@AfterEach` cleanup; inlined the surefire leak rationale into the try/finally
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
