nsivabalan commented on issue #17056: URL: https://github.com/apache/hudi/issues/17056#issuecomment-4800744164
This improvement appears to be already delivered on `master`. The Hudi Trino connector now ships a `HudiCacheKeyProvider` (`hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/cache/HudiCacheKeyProvider.java`) implementing Trino's `CacheKeyProvider`, and it is bound in `HudiModule` (`HudiModule.java:80`): ```java newOptionalBinder(binder, CacheKeyProvider.class).setBinding().to(HudiCacheKeyProvider.class).in(Scopes.SINGLETON); ``` The provider returns cache keys for immutable Hudi data/metadata files and excludes mutable ones (`.hoodie/hoodie.properties`, `.hoodie/.index_defs/index.json`, `.trinoSchema`, `/.trinoPermissions/`). Coverage exists in `TestHudiMemoryCacheFileOperations` and `TestHudiNoCacheFileOperations`, which exercise both `fs.cache.enabled=true` and `false`. This landed in commit `2669933a4907` ([HUDI-9767] Upstream Trino Changes, #13787). Could this issue be closed (or marked resolved against HUDI-9767)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
