cshuo commented on code in PR #19076:
URL: https://github.com/apache/hudi/pull/19076#discussion_r3480142480
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/ttl/strategy/PartitionTTLStrategyType.java:
##########
@@ -67,7 +66,7 @@ public static String
getPartitionTTLStrategyClassName(HoodieConfig config) {
if (config.contains(PARTITION_TTL_STRATEGY_CLASS_NAME)) {
return config.getString(PARTITION_TTL_STRATEGY_CLASS_NAME);
} else if (config.contains(PARTITION_TTL_STRATEGY_TYPE)) {
- return
KeyGeneratorType.valueOf(config.getString(PARTITION_TTL_STRATEGY_TYPE)).getClassName();
+ return
PartitionTTLStrategyType.valueOf(config.getString(PARTITION_TTL_STRATEGY_TYPE)).getClassName();
Review Comment:
Nice catch, Can you add a small unit test to guard against regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
