wombatu-kun commented on code in PR #19092: URL: https://github.com/apache/hudi/pull/19092#discussion_r3492292367
########## hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/ttl/strategy/TestKeepByTimeStrategy.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.table.action.ttl.strategy; + +import org.apache.hudi.config.HoodieWriteConfig; +import org.apache.hudi.table.HoodieTable; + +import org.junit.jupiter.api.Test; + +import java.util.Collections; +import java.util.List; + +import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.never; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +/** + * Tests for {@link KeepByTimeStrategy}. + */ +public class TestKeepByTimeStrategy { + + /** + * Regression test: when there are no candidate partitions to evaluate, + * the strategy must short-circuit and return an empty result instead of + * handing a parallelism of 0 to the engine, which would surface as: + * java.lang.IllegalArgumentException: Positive number of partitions required + * from ParallelCollectionRDD.slice on the Spark path. + */ + @Test + public void getExpiredPartitionsForTimeStrategy_emptyInput_returnsEmptyWithoutTouchingEngine() { Review Comment: This test method drops the `test` prefix that every other test method in this module uses (for example `testSchemaEvolutionEnabled_UsesTableSchema` elsewhere in the `hudi-client-common` test tree). Rename to match, e.g. `testGetExpiredPartitionsForTimeStrategy_emptyInput_returnsEmptyWithoutTouchingEngine`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
