nsivabalan opened a new pull request, #19128:
URL: https://github.com/apache/hudi/pull/19128
Adds hoodie.parquet.small.file.fraction.max.file.size, a new Double-typed
config in HoodieCompactionConfig that expresses the small-file threshold as a
fraction of hoodie.parquet.max.file.size. The threshold is now the single
source of truth at runtime.
An infer function derives the fraction from
hoodie.parquet.small.file.limit / hoodie.parquet.max.file.size when the
fraction key is not explicitly set, so:
- Tables that never set either config see the identical 100MB threshold
they had before (default byte-limit 100MB / default max 120MB, and the accessor
multiplies fraction * max_file_size back to bytes).
- Tables that only set the byte-limit today keep working — the infer
function picks up their user-set value.
- Tables that only bump max.file.size get the byte-limit ratio
automatically scaled to the new max.
- Tables that explicitly set the fraction get it honored; the byte config
is ignored.
- The `small.file.limit=0` disable idiom still trips the `<= 0` check at
every call site because the inferred fraction is 0/max = 0.
HoodieWriteConfig.getParquetSmallFileLimit() now returns long instead of int
and computes (long) (fraction * getParquetMaxFileSize()). All 10 existing call
sites (Spark UpsertPartitioner, Java UpsertPartitioner, Flink WriteProfile,
SparkUpsertDeltaCommitPartitioner, AverageRecordSizeEstimator) already accept
long, so no source edits at any call site.
Added six coverage cases in TestHoodieWriteConfig
(testParquetSmallFileFractionDerivation): default back-compat,
byte-limit-only, fraction-only, both-set precedence, disable sentinel, custom
max size. All 41 tests in TestHoodieWriteConfig pass, and the broader
hudi-client-common suite (1088 tests) stays green.
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
