hudi-agent commented on code in PR #19130:
URL: https://github.com/apache/hudi/pull/19130#discussion_r3503330862
##########
pom.xml:
##########
@@ -2339,6 +2339,24 @@
</execution>
</executions>
</plugin>
+ <!-- Attach the JaCoCo agent so the integration-test (failsafe) and
integ-test unit
+ (surefire) runs emit coverage. The agent argument is appended
to the argLine
+ property, which both plugins pick up. destFile matches the
jacoco-agent path
+ that scripts/jacoco/generate_merged_coverage_report.sh globs
for. -->
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>prepare-agent</goal>
Review Comment:
🤖 One difference from the unit/functional-test profiles worth verifying:
those use `combine.self="append"`, so they keep the managed
`<argLine>@{argLine}</argLine>`. Here the surefire (line 2307) and failsafe
(line 2315) configs use `combine.self="override"`, which drops that managed
`<argLine>` element — so the agent only reaches the forked JVMs via the
implicit `property="argLine"` fallback rather than the late-bound `@{argLine}`.
Could you confirm the `.exec` files actually come out non-empty and Codecov
shows integration-tests coverage? A silent empty upload would still make the
job pass green.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
