danny0405 commented on code in PR #19129:
URL: https://github.com/apache/hudi/pull/19129#discussion_r3503565494
##########
hudi-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java:
##########
@@ -101,7 +107,25 @@ public List<GenericRecord> readAvroRecords(HoodieStorage
storage, StoragePath fi
@Override
public Map<String, String> readFooter(HoodieStorage storage, boolean
required, StoragePath filePath, String... footerNames) {
- throw new UnsupportedOperationException("HFileUtils does not support
readFooter");
+ Map<String, String> footerVals = new HashMap<>();
+ try (HFileReader reader = HFileReaderFactory.builder()
Review Comment:
currently the xxxFileUtils just read the footer by instantiating a fresh new
reader, we might need to do some refactoring if the reader reuse is valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
