danny0405 commented on code in PR #19118:
URL: https://github.com/apache/hudi/pull/19118#discussion_r3505047664
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieLogBlock.java:
##########
@@ -103,6 +109,21 @@ public boolean isDataOrDeleteBlock() {
return getBlockType().isDataOrDeleteBlock();
}
+ protected HoodieSchema getSchemaFromHeader() {
Review Comment:
we have HoodieAvroSchemaCache now, can use it instead.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieDeleteBlock.java:
##########
@@ -137,9 +137,9 @@ public DeleteRecord[] getRecordsToDelete() {
/**
* Returns delete records in the same representation used by the file-group
record buffer.
*/
- public <T> List<BufferedRecord<T>> getRecordsToDelete(RecordContext<T>
recordContext) {
+ public <T> List<BufferedRecord<T>> getRecordsToDelete(HoodieReaderContext<T>
readerContext) {
return Arrays.stream(getRecordsToDelete())
- .map(deleteRecord -> BufferedRecords.fromDeleteRecord(deleteRecord,
recordContext))
+ .map(deleteRecord -> BufferedRecords.fromDeleteRecord(deleteRecord,
readerContext.getRecordContext()))
Review Comment:
why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
