wombatu-kun commented on code in PR #19132:
URL: https://github.com/apache/hudi/pull/19132#discussion_r3511355774
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/others/TestTimeTravelTable.scala:
##########
@@ -338,4 +338,40 @@ class TestTimeTravelTable extends HoodieSparkSqlTestBase {
}
})
}
+
+ test("Test time travel with SQL:2011 temporal clause spellings") {
Review Comment:
The moved timestamp validation has no test coverage. The column-reference /
subquery guard changed from a parse-time ParseException (two distinct messages)
to an analysis-time HoodieAnalysisException (one combined message), and VERSION
AS OF now reaches the 'Version expression is not supported' guard through the
native delegation path. Consider adding negative cases here: a TIMESTAMP AS OF
referencing a column, a TIMESTAMP AS OF with a subquery, and a VERSION AS OF on
a Hudi table - asserting the new exception type and message so a future
regression in the relocated guard is caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
