hudi-agent commented on code in PR #19156:
URL: https://github.com/apache/hudi/pull/19156#discussion_r3519726696
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/HoodieFlinkCompactor.java:
##########
@@ -367,7 +367,7 @@ private void compact() throws Exception {
* Shutdown async services like compaction/clustering as DeltaSync is
shutdown.
*/
public void shutdownAsyncService(boolean error) {
- LOG.info("Gracefully shutting down compactor. Error ?" + error);
+ LOG.info("Gracefully shutting down compactor. Error ?{}", error);
Review Comment:
🤖 nit: same `"Error ?{}"` oddity as in `HoodieFlinkClusteringJob` — `"Error:
{}"` would read more naturally.
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/HoodieFlinkClusteringJob.java:
##########
@@ -418,7 +418,7 @@ private void cluster() throws Exception {
* Shutdown async services like compaction/clustering as DeltaSync is
shutdown.
*/
public void shutdownAsyncService(boolean error) {
- LOG.info("Gracefully shutting down clustering job. Error ?" + error);
+ LOG.info("Gracefully shutting down clustering job. Error ?{}", error);
Review Comment:
🤖 nit: `"Error ?{}"` reads oddly now that it's a parameterized placeholder —
the `?` looks like a stray ternary fragment. Could you change it to `"Error:
{}"`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
