yihua opened a new pull request, #19162:
URL: https://github.com/apache/hudi/pull/19162

   ### Change Logs
   
   Adds test coverage for the Spark catalog integration in hudi-spark-common, 
which was under-covered (~471 missed lines across the catalog/command classes). 
New/extended suites in hudi-spark:
   
   - `TestHoodieCatalogDDL` — DDL-level coverage for `HoodieCatalog`, 
`HoodieStagedTable`, `HoodieInternalV2Table`, `ShowHoodieCreateTableCommand`, 
and `CreateHoodieTableCommand`, driven through the V2 session catalog 
(`spark_catalog = HoodieCatalog`): catalog-API create/load/alter/rename/drop, 
CTAS commit and abort via the staged table, `SHOW CREATE TABLE` DDL 
regeneration, existing-location property validation, and the V2 table 
read/write path under schema evolution. `HoodieStagedTable` and 
`ShowHoodieCreateTableCommand` were previously at 0%.
   - `TestSparkCatalogMetaStoreClient` — adds supported edge cases (empty 
partitions, no-op `setMetaConf`, default database location) and a contract test 
asserting the unsupported `IMetaStoreClient` surface fails fast with 
`UnsupportedOperationException`.
   - `TestHoodieSqlCommonUtils` — unit coverage for the remaining 
`HoodieSqlCommonUtils` helpers (instant formatting, partition-style detection, 
config filtering, partition-spec normalization, path qualification).
   
   Every test asserts observable behavior (rows, table metadata, generated DDL, 
or thrown exceptions); no assertion-free execution and no sleeps.
   
   ### Impact
   
   Test-only. No production code changes.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   None.
   
   ### Contributor's checklist
   - [x] Read through the contributor's guide
   - [x] Change is test-only and behavior-preserving
   - [x] Tests assert meaningful behavior
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to