hudi-agent commented on code in PR #19159:
URL: https://github.com/apache/hudi/pull/19159#discussion_r3522956255
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/MetadataCommand.java:
##########
@@ -351,34 +351,33 @@ public String validateFiles(
}
if (metadataPathInfoList.size() != pathInfoList.size()) {
- log.error(" FS and metadata files count not matching for " + partition
- + ". FS files count " + pathInfoList.size()
- + ", metadata base files count " + metadataPathInfoList.size());
+ log.error(" FS and metadata files count not matching for {}. FS files
count {}, metadata base files count {}", partition, pathInfoList.size(),
metadataPathInfoList.size());
}
for (Map.Entry<String, StoragePathInfo> entry : pathInfoMap.entrySet()) {
if (!metadataPathInfoMap.containsKey(entry.getKey())) {
- log.error("FS file not found in metadata " + entry.getKey());
+ log.error("FS file not found in metadata {}", entry.getKey());
} else {
if (entry.getValue().getLength()
!= metadataPathInfoMap.get(entry.getKey()).getLength()) {
- log.error(" FS file size mismatch " + entry.getKey() + ", size
equality "
- + (entry.getValue().getLength()
- == metadataPathInfoMap.get(entry.getKey()).getLength())
- + ". FS size " + entry.getValue().getLength()
- + ", metadata size " +
metadataPathInfoMap.get(entry.getKey()).getLength());
+ log.error(" FS file size mismatch {}, size equality {}. FS size
{}, metadata size {}",
+ entry.getKey(),
+ entry.getValue().getLength() ==
metadataPathInfoMap.get(entry.getKey()).getLength(),
+ entry.getValue().getLength(),
+ metadataPathInfoMap.get(entry.getKey()).getLength());
}
}
}
for (Map.Entry<String, StoragePathInfo> entry :
metadataPathInfoMap.entrySet()) {
if (!pathInfoMap.containsKey(entry.getKey())) {
- log.error("Metadata file not found in FS " + entry.getKey());
+ log.error("Metadata file not found in FS {}", entry.getKey());
} else {
if (entry.getValue().getLength() !=
pathInfoMap.get(entry.getKey()).getLength()) {
- log.error(" Metadata file size mismatch " + entry.getKey() + ",
size equality "
- + (entry.getValue().getLength() ==
pathInfoMap.get(entry.getKey()).getLength())
- + ". Metadata size " + entry.getValue().getLength() + ", FS
size "
- + metadataPathInfoMap.get(entry.getKey()).getLength());
+ log.error(" Metadata file size mismatch {}, size equality {}.
Metadata size {}, FS size {}",
+ entry.getKey(),
+ entry.getValue().getLength() ==
pathInfoMap.get(entry.getKey()).getLength(),
+ entry.getValue().getLength(),
+ metadataPathInfoMap.get(entry.getKey()).getLength());
Review Comment:
🤖 Since you're rewriting this statement anyway — in this loop `entry` comes
from `metadataPathInfoMap`, so
`metadataPathInfoMap.get(entry.getKey()).getLength()` is just
`entry.getValue().getLength()` again (the metadata size). The `FS size {}` arg
looks like it should be `pathInfoMap.get(entry.getKey()).getLength()` instead,
matching the equality check on the line above. Could you confirm?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
