hudi-agent commented on code in PR #19185:
URL: https://github.com/apache/hudi/pull/19185#discussion_r3523521861
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/DFSPathSelector.java:
##########
@@ -125,8 +125,7 @@ public Pair<Option<String>, Checkpoint>
getNextFilePathsAndMaxModificationTime(O
long sourceLimit) {
try {
// obtain all eligible files under root folder.
- log.info("Root path => " + getStringWithAltKeys(props,
DFSPathSelectorConfig.ROOT_INPUT_PATH)
- + " source limit => " + sourceLimit);
+ log.info("Root path => {} source limit => {}",
getStringWithAltKeys(props, DFSPathSelectorConfig.ROOT_INPUT_PATH),
sourceLimit);
Review Comment:
🤖 nit: the original was split across two lines for a reason — this collapsed
form comes out to ~135 chars and is a bit of a wall to read. Could you keep the
arguments on their own line, e.g. `log.info("Root path => {} source limit =>
{}",\n getStringWithAltKeys(...), sourceLimit);`?
<sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
