hudi-agent commented on code in PR #19192: URL: https://github.com/apache/hudi/pull/19192#discussion_r3525868143
########## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/HoodieMetadataBloomFilterProbingFunction.java: ########## @@ -31,6 +30,7 @@ import org.apache.hudi.exception.HoodieIndexException; import org.apache.hudi.metadata.HoodieBackedTableMetadata; import org.apache.hudi.table.HoodieTable; +import org.apache.hudi.util.LazyIterableIterator; Review Comment: 🤖 Since `LazyIterableIterator` moves from `org.apache.hudi.client.utils` to `org.apache.hudi.util` here, it might be worth also updating its attribution in the top-level `LICENSE` file — line ~219 still lists `org.apache.hudi.client.utils.LazyIterableIterator` for the adapted Apache SystemML code. ASF release audits check those paths, so easy to catch now while the relocation is fresh. Non-blocking. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/execution/estimator/RecordSizeEstimator.java: ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.hudi.estimator; +package org.apache.hudi.execution.estimator; Review Comment: 🤖 Since `RecordSizeEstimator` is a `@PublicAPIClass`, this FQN move is a source break for any custom estimator implementations (they'll need to update imports). Worth noting `RecordSizeEstimatorFactory` catches `Throwable` and silently falls back to the default `AverageRecordSizeEstimator` (only a WARN), so a stale `hoodie.record.size.estimator.class` pointing at the old FQN won't fail loudly — it just quietly ignores the user's setting. Given it's the deliberate `!` break, is the package change captured in the migration/release notes? @bvaradar for the public-API judgment. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/util/LazyIterableIterator.java: ########## @@ -16,7 +16,7 @@ * limitations under the License. */ -package org.apache.hudi.client.utils; +package org.apache.hudi.util; Review Comment: 🤖 Since `LazyIterableIterator` moved to `org.apache.hudi.util`, the Apache SystemML attribution in the top-level `LICENSE` file (line 219) still points at the old `org.apache.hudi.client.utils.LazyIterableIterator` path. Might be worth updating that reference in the same PR to keep the LICENSE accurate. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> ########## hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/LazyCastingIterator.java: ########## @@ -20,7 +20,7 @@ package org.apache.hudi.utilities.schema; import org.apache.hudi.avro.HoodieAvroUtils; -import org.apache.hudi.client.utils.LazyIterableIterator; +import org.apache.hudi.util.LazyIterableIterator; Review Comment: 🤖 Since `LazyIterableIterator` moved to `org.apache.hudi.util` (reflected in this import), the SystemML attribution in the root `LICENSE` file still points to the old path — line 219 reads `org.apache.hudi.client.utils.LazyIterableIterator`. Might be worth updating that entry to the new FQN so the third-party attribution stays accurate for the release. <sub><i>⚠️ AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
