cshuo opened a new pull request, #19201: URL: https://github.com/apache/hudi/pull/19201
…text ### Describe the issue this Pull Request addresses This PR removes the redundant `RecordContext#convertPartitionValueToEngineType` API. The method only forwarded to `convertValueToEngineType`, and the Spark-specific override duplicated the same String-to-`UTF8String` conversion behavior already provided by Spark's regular value conversion path. This keeps partition filter value conversion in `HoodieFileGroupReader` aligned with the general engine-native value conversion contract. ### Summary and Changelog - Removed `RecordContext#convertPartitionValueToEngineType`. - Removed the redundant Spark override from `BaseSparkInternalRecordContext`. - Updated `HoodieFileGroupReader` to call `convertValueToEngineType` directly when building bootstrap partition filter values. - Updated `TestSparkFileFormatInternalRowReaderContext` to validate Spark value conversion through `SparkFileFormatInternalRecordContext#convertValueToEngineType`. ### Impact - **Functional impact**: No intended behavior change. Partition values continue to use the same engine-native conversion behavior as before. - **Maintainability**: Removes a redundant API surface and duplicated Spark conversion logic. - **Extensibility**: Keeps engine-native value conversion centralized in `convertValueToEngineType`, while ordering/comparability concerns remain separate. ### Risk Level Low. ### Documentation Update none ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Enough context is provided in the sections above - [ ] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
