danny0405 commented on code in PR #19198: URL: https://github.com/apache/hudi/pull/19198#discussion_r3529460837
########## hudi-common/src/main/java/org/apache/hudi/common/fs/FileNameParser.java: ########## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.fs; + +import org.apache.hudi.common.table.cdc.HoodieCDCUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.StringUtils; +import org.apache.hudi.exception.HoodieValidationException; +import org.apache.hudi.storage.StoragePath; + +import lombok.Getter; + +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Parser for Hudi-generated base and log file names. + * + * <p>The parser accepts either a file name or a full path and always decodes only the last path component. + * A non-matching input returns {@link Option#empty()} instead of throwing.</p> + */ +public final class FileNameParser { + // Inline log files are of this pattern - .b5068208-e1a4-11e6-bf01-fe55135034f3_20170101134598.log.1_1-0-1 + // Inline archive log files are of this pattern - .commits_.archive.1_1-0-1 + // Native log files are of this pattern - b5068208-e1a4-11e6-bf01-fe55135034f3_1-0-1_20170101134598_1.log.parquet + // For native log files, the file extension is log/deletes/cdc and the suffix is the native file format. + + static final Pattern INLINE_LOG_FILE_PATTERN = + Pattern.compile("^\\.([^._]+)_([^.]*)\\.(log|archive)\\.(\\d+)(_((\\d+)-(\\d+)-(\\d+))(\\.cdc)?)?$"); + static final Pattern NATIVE_LOG_FILE_PATTERN = + Pattern.compile("^([^._]+)_((\\d+)-(\\d+)-(\\d+))_([^_]+)_(\\d+)\\.(log|deletes|cdc)\\.([^.]+)$"); + static final Pattern BASE_FILE_PATTERN = Pattern.compile("[a-zA-Z0-9-]+_[a-zA-Z0-9-]+_[0-9]+\\.[a-zA-Z0-9]+"); + private static final Pattern PREFIX_BY_FILE_ID_PATTERN = Pattern.compile("^(.+)-(\\d+)"); + + private FileNameParser() { + } + + /** + * Parses a Hudi-generated base file name. + * + * <p>Expected format: {@code <fileId>_<writeToken>_<commitTime>.<extension>}. + * The decoded {@link BaseFileName#getFileExtension()} value includes the leading dot, matching existing + * base-file helper API behavior.</p> + * + * @param fileName file name or full path + * @return decoded base file name when the input matches the Hudi base-file format + */ + public static Option<BaseFileName> parseBaseFile(String fileName) { + if (StringUtils.isNullOrEmpty(fileName)) { + return Option.empty(); + } + + String actualFileName = getActualFileName(fileName); + Matcher matcher = BASE_FILE_PATTERN.matcher(actualFileName); + if (!matcher.matches()) { + return Option.empty(); + } + + int firstUnderscoreIndex = actualFileName.indexOf('_'); Review Comment: Thanks. We kept base-file parsing aligned with the historical HoodieBaseFile/origin-master substring scan instead of switching to regex group extraction, so this validator/extractor concern is no longer applicable in the current revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
