wombatu-kun commented on code in PR #19218: URL: https://github.com/apache/hudi/pull/19218#discussion_r3545384105
########## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestExtendedSqlParserCoverage.scala: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.hudi.command.index + +import org.apache.hudi.common.schema.{HoodieSchema, HoodieSchemaType} + +import org.apache.spark.sql.catalyst.TableIdentifier +import org.apache.spark.sql.catalyst.analysis.UnresolvedRelation +import org.apache.spark.sql.catalyst.plans.logical.{CreateIndex, DropIndex, HoodieShowIndexes, RefreshIndex} +import org.apache.spark.sql.hudi.common.HoodieSparkSqlTestBase +import org.apache.spark.sql.types.{ArrayType, BlobType, FloatType} + +/** + * Coverage for the Hudi-specific surface of the extended SQL parser: index DDL + * (CREATE / DROP / SHOW / REFRESH INDEX) and Hudi column types (BLOB, VECTOR). + * + * Index DDL is asserted on the parsed logical plan directly, since those plan + * classes are Hudi-owned and stable across Spark versions. Column types are + * asserted through the catalog schema, which stays version-agnostic even though + * the CreateTable plan fields differ between Spark 3.5 and 4.x. + */ +class TestExtendedSqlParserCoverage extends HoodieSparkSqlTestBase { + + // parsePlan is purely syntactic and never consults the catalog, so the index-DDL + // tests below parse against table names that are never created. + private def parse(sql: String) = spark.sessionState.sqlParser.parsePlan(sql) + + private def tableName(plan: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan): Seq[String] = + plan.children.head.asInstanceOf[UnresolvedRelation].multipartIdentifier + + test("Test parse CREATE INDEX into a CreateIndex plan") { + val tableName = generateTableName + val plan = parse(s"create index idx_name on $tableName using bloom (name)") + assertResult(classOf[CreateIndex].getName)(plan.getClass.getName) + val createIndex = plan.asInstanceOf[CreateIndex] + assertResult("idx_name")(createIndex.indexName) + assertResult("bloom")(createIndex.indexType) + assert(this.tableName(createIndex).last.equalsIgnoreCase(tableName)) + } + + test("Test parse DROP INDEX into a DropIndex plan") { + val tableName = generateTableName + val plan = parse(s"drop index idx_name on $tableName") + assertResult(classOf[DropIndex].getName)(plan.getClass.getName) + val dropIndex = plan.asInstanceOf[DropIndex] + assertResult("idx_name")(dropIndex.indexName) + assert(this.tableName(dropIndex).last.equalsIgnoreCase(tableName)) + } + + test("Test parse SHOW INDEXES into a HoodieShowIndexes plan") { + val tableName = generateTableName + val plan = parse(s"show indexes from $tableName") + assertResult(classOf[HoodieShowIndexes].getName)(plan.getClass.getName) + assert(this.tableName(plan).last.equalsIgnoreCase(tableName)) + } + + test("Test parse REFRESH INDEX into a RefreshIndex plan") { + val tableName = generateTableName + val plan = parse(s"refresh index idx_name on $tableName") + assertResult(classOf[RefreshIndex].getName)(plan.getClass.getName) + val refreshIndex = plan.asInstanceOf[RefreshIndex] + assertResult("idx_name")(refreshIndex.indexName) + assert(this.tableName(refreshIndex).last.equalsIgnoreCase(tableName)) + } + + test("Test parse a BLOB column type into the catalog schema") { Review Comment: This BLOB test (and the VECTOR test below) reproduces coverage that `TestCreateTable` and `TestBlobDataType` already provide: same create-table into the catalog, same `hudi_type` metadata and `dataType` assertions. The CREATE/DROP/SHOW index tests likewise overlap `TestIndexSyntax`, which parses the same DDL and asserts the index name, type, and options. REFRESH INDEX is the only case with no existing coverage. Consider narrowing this suite to the genuinely new gap (REFRESH INDEX parse), or, if the intent is a parse-only layer distinct from those suites, note that so the overlap reads as deliberate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
