voonhous opened a new pull request, #19235:
URL: https://github.com/apache/hudi/pull/19235
Parquet 1.16.0 (used by Spark 4.1) split VARIANT support into a separate
`parquet-variant` artifact that carries
`org.apache.parquet.variant.VariantConverters`. `parquet-avro:1.16.0` — which
the hudi-spark-bundle shades and uses on the read path — references it. The
bundle's shade `<includes>` is an allowlist that listed parquet-avro but not
parquet-variant, so the class was dropped from the bundle and absent at runtime.
Result: on Spark 4.1 every read-modify write (UPDATE / MERGE INTO / DELETE)
aborted with `java.lang.NoClassDefFoundError:
org/apache/parquet/variant/VariantConverters$ParentConverter`; only the initial
INSERT succeeded. This surfaced as the custom-type hive-sync E2E
(ITTestCustomTypeHiveSync) failing on `SHOW PARTITIONS` (the second partition
was never committed), masked by the fixtures' unconditional success markers.
parquet-variant is a transitive compile dep of parquet-avro, so adding it to
the shade include list bundles it for Spark 4.1/4.2 and is a no-op for older
Spark (the artifact does not exist before Parquet 1.16.0). Verified the rebuilt
spark4.1 bundle now contains `VariantConverters$ParentConverter`.
Fixes apache/hudi#19234
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]