voonhous commented on code in PR #19236:
URL: https://github.com/apache/hudi/pull/19236#discussion_r3557354320
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/execution/datasources/lance/SparkLanceReaderBase.scala:
##########
@@ -131,10 +131,10 @@ class SparkLanceReaderBase(enableVectorizedReader:
Boolean) extends SparkColumna
null
}
- // Honor `hoodie.read.blob.inline.mode`. CONTENT (default)
materializes INLINE bytes in
- // the `data` column; DESCRIPTOR surfaces per-row {position, size}
which the descriptor
- // iterator rewrites into Hudi OUT_OF_LINE references. Non-blob Lance
columns ignore
- // the option regardless.
+ // Honor `hoodie.read.blob.inline.mode`. DESCRIPTOR (default) surfaces
per-row
+ // {position, size} which the descriptor iterator rewrites into Hudi
OUT_OF_LINE
Review Comment:
Right, the transform keeps type=INLINE and only synthesizes the reference;
never emits OUT_OF_LINE. Reworded as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
