voonhous commented on code in PR #19244:
URL: https://github.com/apache/hudi/pull/19244#discussion_r3563504301
##########
.github/workflows/bot.yml:
##########
@@ -17,7 +17,12 @@ concurrency:
cancel-in-progress: ${{ !contains(github.ref, 'master') &&
!contains(github.ref, 'branch-0.x') && !contains(github.ref, 'release-') }}
env:
- MVN_ARGS: -e -ntp -B -V -Dgpg.skip -Djacoco.skip -Pwarn-log
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn
-Dmaven.wagon.httpconnectionManager.ttlSeconds=25
-Dmaven.wagon.http.retryHandler.count=5 -Dorg.eclipse.jetty.LEVEL=WARN
+ # The retry/timeout knobs below are maven-resolver (aether.*) properties.
Maven 3.9 resolves
+ # artifacts through the native resolver HTTP transport, which ignores the
older maven.wagon.* names.
+ # serviceUnavailable lists the HTTP codes retried instead of failing the
build. 403 is deliberately
+ # absent: Maven Central answers 403 when its CDN has blocked the runner's
egress IP, and retrying
+ # that is what escalates the block.
+ MVN_ARGS: -e -ntp -B -V -Dgpg.skip -Djacoco.skip -Pwarn-log
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn
-Daether.connector.http.retryHandler.count=5
-Daether.connector.http.retryHandler.interval=3000
-Daether.connector.http.retryHandler.intervalMax=30000
-Daether.connector.http.retryHandler.serviceUnavailable=429,500,502,503,504
-Daether.connector.http.connectionMaxTtl=25 -Dorg.eclipse.jetty.LEVEL=WARN
Review Comment:
This drops the `maven.wagon.*` flags entirely, whereas azure keeps both
sets. Fine as long as every MVN_ARGS job runs on the GH-hosted Maven 3.9.x
(native resolver transport), which is the case today. Just flagging it only
works because nothing here runs Maven 3.8 -- if a job ever did, it would
silently lose all retry config, since the `aether.*` names are ignored by
wagon. The azure asymmetry is intentional and correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
