codope commented on code in PR #19277:
URL: https://github.com/apache/hudi/pull/19277#discussion_r3571721110
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/BaseHoodieTimeline.java:
##########
@@ -378,7 +378,7 @@ public HoodieTimeline getCommitsAndCompactionTimeline() {
public HoodieTimeline getAllCommitsTimeline() {
return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION,
DELTA_COMMIT_ACTION,
CLEAN_ACTION, COMPACTION_ACTION, SAVEPOINT_ACTION, ROLLBACK_ACTION,
REPLACE_COMMIT_ACTION, CLUSTERING_ACTION,
- INDEXING_ACTION, LOG_COMPACTION_ACTION));
+ INDEXING_ACTION, LOG_COMPACTION_ACTION, RESTORE_ACTION));
Review Comment:
Restore is a meta-action that undoes commits back to a savepoint. The
individual rollbacks produced by a restore already appear on the timeline as
ROLLBACK_ACTION instants. Also, getRollbackAndRestoreTimeline() gives you
rollback and restore timeline. Though I see no harm in including the
RESTORE_ACTION in getAllCommitsTimeline() for completeness, did you see any
issue because of missing restore action?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
