danny0405 commented on code in PR #19242:
URL: https://github.com/apache/hudi/pull/19242#discussion_r3575359243
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -220,7 +220,7 @@ void
testStreamReadFromSpecifiedCommitWithChangelog(HoodieCDCSupplementalLogging
.option(FlinkOptions.READ_STREAMING_SKIP_COMPACT, false)
.option(FlinkOptions.CDC_ENABLED, true)
.option(FlinkOptions.SUPPLEMENTAL_LOGGING_MODE, mode.name())
- .option(FlinkOptions.READ_SOURCE_V2_ENABLED, useSourceV2)
+ .option(FlinkOptions.READ_SOURCE_V2_ENABLED, true)
Review Comment:
`useSourceV2` is still supplied as both `false` and `true` for every
supplemental logging mode, but forcing `true` here makes each pair of
parameterized invocations identical and removes all Source V1 CDC coverage.
This is also unrelated to the Lance nested-type change. Could we restore
`useSourceV2` here (or, if Source V1 is intentionally no longer supported,
remove the boolean parameter/cases in a separate change with the rationale)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
