danny0405 commented on code in PR #18984:
URL: https://github.com/apache/hudi/pull/18984#discussion_r3575446896
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfigHolder.java:
##########
@@ -122,6 +122,23 @@ public class HiveSyncConfigHolder {
.defaultValue(1000)
.markAdvanced()
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.");
+ public static final ConfigProperty<Boolean> HIVE_SYNC_BATCHING_ENABLED =
ConfigProperty
+ .key("hoodie.datasource.hive_sync.batching.enabled")
+ .defaultValue(false)
+ .markAdvanced()
+ .sinceVersion("1.1.0")
+ .withDocumentation("When true, partition operations
(add/update/touch/drop) in the active sync mode "
Review Comment:
This description overstates the feature scope: the pool is only constructed
for HiveQL execution, while HMS/JDBC modes are unchanged and DROP remains
serial. It also describes every operation as being split into batches, although
ADD was already batched and SET_LOCATION still emits one statement per
partition. Could we scope the generated docs precisely to parallel HiveQL
dispatch of the operations implemented here?
##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfigHolder.java:
##########
@@ -122,6 +122,23 @@ public class HiveSyncConfigHolder {
.defaultValue(1000)
.markAdvanced()
.withDocumentation("The number of partitions one batch when synchronous
partitions to hive.");
+ public static final ConfigProperty<Boolean> HIVE_SYNC_BATCHING_ENABLED =
ConfigProperty
+ .key("hoodie.datasource.hive_sync.batching.enabled")
+ .defaultValue(false)
+ .markAdvanced()
+ .sinceVersion("1.1.0")
Review Comment:
These two configuration keys are introduced on the current `1.3.0-SNAPSHOT`
branch, but both are tagged as available since `1.1.0`. That will make the
generated configuration documentation claim the properties exist in older
releases. Please change both `sinceVersion` values to `1.3.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
